Bringing release up to Q2 2023 (#32)

* Development (#24) (#25)

* canada/bc/natcrz.f - remove tabs
canada/newmist/DMCOM.F77 - set DMTINY threshold to 1.0e-10
canada/newmist/dbsmis.f - remove tabs
canada/newmist/dmcycl.f - correct spin-up of life-history pools
canada/newmist/dminitbc.f - correct crownthird pool initialization to match documentation
canada/newmist/dmtreg.f - simplify crownthird assignment from inventory
metric/base/evldx.f - remove unused variables
metric/dbsqlite/dbsingrow.f - remove unused variables
metric/dbsqlite/dbsmis.f - remove unused variables, convert crownthird breakpoints to meters
metric/dbsqlite/dbstrls.f - remove unused variables
tests/FVSbc/YSM-SkyRanch.sum.save - update results (correction of spin-up)
tests/FVSbc/YSM-SkyRanchDBdump.txt.save - update results (correction of spin-up)

* canada/newmist/dbsmis.f - old copy superceded by dbsqlite version

* metric/vdbsqlite/dbssumry.f - correct mid-cycle post-treatment CCF in output

* canada/on/balmod.f - tidy up <tab> characters
canada/on/rgnthw.f - tidy up <tab> characters
metric/dbsqlite/dbsfmmort.f - tidy up spaces
metric/dbsqlite/dbsmis.f - move finalize before commit (needs more testing)
metric/dbsqlite/dbstrls.f - move finalize before commit
metric/dbsqlite/dbssumry.f - tidy up spaces
mistoe/mismrt.f - simplify mortality model for Elytroderma model testing

* Changes in sourceList files and file names in ../volume needed to
compile on linux

* Changes needed to compile on Linux

* Replaced the general purpose revise.f with the canada/bc version.
Simplified the canada/bc version.

* * Replaced the general purpose revise.f with the canada/on version.
Simplified the canada/on version.

* mistoe/mismrt.f - revert accidentally committed temporary change to DM mortality

* Per NCrookston "Added support for setting up a harvest using the rFVS function fvsCutNow
    where the proportion of each tree to be harvested is set externally"

* Fixed the FVSon_sourceList.txt file by removing vvolume/fvsvol.f,
updated apisubs.f and cuts.f to support additions for "cutnow" rFVS
option.

* Copied files from FMSCrelease to resolve the remaining difference as of
20230112

* VOLINIT.F Clean Up Updates
volinit.f: FIAVTYPE, NVELEQ are uninitialzed prior to but defined in call to fiaeq2nveleq.
  Initialize to empty char array for cleaner code

  GEOSUB: Declared in VOLINIT.F but not initialized before being passed to
  FIAEQ2NVELEQ where it is never assigned but is evaluated and referenced in note:
  "! GEOSUB is the variable used for Alaska equation for Afognak Island (input as 'AFO')
!        also Clark equation geocode (1 to 7) and Lasher EQ geocode (01 to 32)"
GEOSUB is not defined and initialized or included in any other common block or module
use instance.  Does not appear to be a way GEOSUB to ever evaluate to TRUE for the above,
at least not from being called from VOLINIT.f

REAL         TIPDIB,TIPLEN: Declared in VOLINIT.F, never initialized, never used, never mentioned again
(Find only returns the single instance (definition) )

REAL         CR: Declared in VOLINIT.F, never initialized, never used, never mentioned again
(Find only returns past usage that has since been commented out, as well as the single instance (definition) )

REAL         STUMPDIB, STUMPDOB: Declared in VOLINIT.F, never initialized, never used, never mentioned again
(Find only returns the single instance (definition) )

REAL         VOLIB, VOLOB: Declared in VOLINIT.F but not initialized prior to passing to RAILEVOL() where it is quickly assigned

REAL         DIB, DOB: Declared in VOLINIT.F but not initialized prior to being passed to CALCDIA2().  Will initialize each to 0.

REAL         FIAVOL Declared in VOLINIT.F.  Only instance of use has been commented out.  Can delete

REAL WF(3), BMS(8) Declared in VOLINIT.F.  Unused

INTEGER SPCD, FOREST Declared in VOLINIT.F.  Unused.

* BLMTAP.F: Removal and replacement of TAB characters

Comment out unused variable
   14 |       INTEGER    Profile,ILIMIT,ICOUNT,profileht
      |                                                1
Warning: Unused variable 'profileht' declared at (1) [-Wunused-variable]

C Temporary comment out of apparent unused variables, delete after test comfirms - 01/2023 DW
C      REAL         DBHIB

BLMVOL.F: Removal and replacement of TAB characters
blmvol.f:31:49:
Comment out:
   31 |       INTEGER PROFILE, bfpflg,cupflg,tlogs,ITAPER
      |                                                 1
Warning: Unused variable 'itaper' declared at (1) [-Wunused-variable]

blmvol.f:30:60:

   30 |       INTEGER EVOD,NUMSEG,OPT,TAPEQU,FCLASS,ERRFLAG,I,J,lcnt
      |                                                            1
Warning: Unused variable 'lcnt' declared at (1) [-Wunused-variable]

CalcDia.F: Removal and replacement of TAB characters

* Changed CHAR array length from 40 to 48 to address:
CRZBIOMASS.F:57:72:

   57 |             REF(6) = 'USE REGIONAL DEFAULT WEIGHT FACTOR (SECOND)'
      |                                                                        1
Warning: CHARACTER expression will be truncated in assignment (40/43) at (1) [-Wcharacter-truncation]
CRZBIOMASS.F:64:72:

   64 |              REF(6) = 'USE REGIONAL DEFAULT WEIGHT FACTOR (PRIM)'
      |                                                                        1
Warning: CHARACTER expression will be truncated in assignment (40/41) at (1) [-Wcharacter-truncation]
CRZBIOMASS.F:72:72:

   72 |             REF(5) = 'USE REGIONAL DEFAULT WEIGHT FACTOR (PRIM)'
      |                                                                        1
Warning: CHARACTER expression will be truncated in assignment (40/41) at (1) [-Wcharacter-truncation]
Files involved include:
CalcBiomass.F, subroutine getwtfactor_r
CRZBIOMASS.F, subroutine crzspdft, subroutine CRZBIOMASS
volibcs.f, subroutnine crzspdftcs
volumelibrary.f, subroutine BIOLIB, subroutine BIOLIB2

* Added initialization of drcq and drcp, which according to Chojnack, D. C. and Rogers, P. Converting Tree Diameter Measured at Root Collar
 to Diameter at Breast Height. WJAF 14(1), 1999, should be zero if not used
CRZBIOMASS.F:356:72:

  356 |      &   +0.7469*Pied-0.0399*drcp+1.2244*Quga-0.0689*drcq
      |                                                                        ^
Warning: 'drcq' may be used uninitialized [-Wmaybe-uninitialized]
CRZBIOMASS.F:335:35:

  335 |       REAL DRCOB, DBHOB, drcp, drcq
      |                                   ^
note: 'drcq' was declared here
CRZBIOMASS.F:356:72:

  356 |      &   +0.7469*Pied-0.0399*drcp+1.2244*Quga-0.0689*drcq
      |                                                                        ^
Warning: 'drcp' may be used uninitialized [-Wmaybe-uninitialized]
CRZBIOMASS.F:335:29:

  335 |       REAL DRCOB, DBHOB, drcp, drcq
      |                             ^
note: 'drcp' was declared here

dvest.f: Removed and replaced TAB characters
f_alaska: Removed and replaced TAB characters
f_ingy.f: Removed and replaced TAB characters
f_other.f: Removed and replaced TAB characters

Cast MLOGS to INT - INT(MLOGS)
fia_ak_vol.for:327:20:

  327 |         DO 10 I = 1,MLOGS
      |                    1
Warning: Deleted feature: End expression in DO loop at (1) must be integer

fia_ak_vol.f: Initialized variables

* Updated official SN/sitset.f
Updated merchantability specifications for National Forests in NC, per FSH 2409.18 Ch 50 Supplement R8_NC_2409.18-2022-1

* Update estab.f

Additional comments and debug statements were added for documentation purposes and to hopefully clarify some of the logic in this routine.

* Update estab.f

* Clean up of R5_EGN subroutine
Corrected other softwood FIA code in SO variant blkdat

* Updated REV number for Q1 supplemental release

* Corrections to forest type algorithm when computing
other softwoods.  Change resultant from change of OS FIA code from 298 to 299.

Update to test/FVSie/DBReportTest_dump.txt.save
corrects issue with reporting ATCCF instead of BTCCF

* Corrections Included:
Corrected mapping issue for CR location 7104 to map to 203 (IFOR = 2) as misscoded I = 2)
Updated AK voleq for alder

---------

Co-authored-by: Don Robinson <drobinson@essa.com>
Co-authored-by: Nicholas Crookston <ncrookston.fs@gmail.com>
Co-authored-by: LANCE R. DAVID <lance.david@usda.gov>
Co-authored-by: markcastle1415 <mark.castle@usda.gov>

* Staging (#31)

* canada/bc/natcrz.f - remove tabs
canada/newmist/DMCOM.F77 - set DMTINY threshold to 1.0e-10
canada/newmist/dbsmis.f - remove tabs
canada/newmist/dmcycl.f - correct spin-up of life-history pools
canada/newmist/dminitbc.f - correct crownthird pool initialization to match documentation
canada/newmist/dmtreg.f - simplify crownthird assignment from inventory
metric/base/evldx.f - remove unused variables
metric/dbsqlite/dbsingrow.f - remove unused variables
metric/dbsqlite/dbsmis.f - remove unused variables, convert crownthird breakpoints to meters
metric/dbsqlite/dbstrls.f - remove unused variables
tests/FVSbc/YSM-SkyRanch.sum.save - update results (correction of spin-up)
tests/FVSbc/YSM-SkyRanchDBdump.txt.save - update results (correction of spin-up)

* canada/newmist/dbsmis.f - old copy superceded by dbsqlite version

* metric/vdbsqlite/dbssumry.f - correct mid-cycle post-treatment CCF in output

* canada/on/balmod.f - tidy up <tab> characters
canada/on/rgnthw.f - tidy up <tab> characters
metric/dbsqlite/dbsfmmort.f - tidy up spaces
metric/dbsqlite/dbsmis.f - move finalize before commit (needs more testing)
metric/dbsqlite/dbstrls.f - move finalize before commit
metric/dbsqlite/dbssumry.f - tidy up spaces
mistoe/mismrt.f - simplify mortality model for Elytroderma model testing

* Changes in sourceList files and file names in ../volume needed to
compile on linux

* Changes needed to compile on Linux

* Replaced the general purpose revise.f with the canada/bc version.
Simplified the canada/bc version.

* * Replaced the general purpose revise.f with the canada/on version.
Simplified the canada/on version.

* mistoe/mismrt.f - revert accidentally committed temporary change to DM mortality

* Per NCrookston "Added support for setting up a harvest using the rFVS function fvsCutNow
    where the proportion of each tree to be harvested is set externally"

* Fixed the FVSon_sourceList.txt file by removing vvolume/fvsvol.f,
updated apisubs.f and cuts.f to support additions for "cutnow" rFVS
option.

* Copied files from FMSCrelease to resolve the remaining difference as of
20230112

* VOLINIT.F Clean Up Updates
volinit.f: FIAVTYPE, NVELEQ are uninitialzed prior to but defined in call to fiaeq2nveleq.
  Initialize to empty char array for cleaner code

  GEOSUB: Declared in VOLINIT.F but not initialized before being passed to
  FIAEQ2NVELEQ where it is never assigned but is evaluated and referenced in note:
  "! GEOSUB is the variable used for Alaska equation for Afognak Island (input as 'AFO')
!        also Clark equation geocode (1 to 7) and Lasher EQ geocode (01 to 32)"
GEOSUB is not defined and initialized or included in any other common block or module
use instance.  Does not appear to be a way GEOSUB to ever evaluate to TRUE for the above,
at least not from being called from VOLINIT.f

REAL         TIPDIB,TIPLEN: Declared in VOLINIT.F, never initialized, never used, never mentioned again
(Find only returns the single instance (definition) )

REAL         CR: Declared in VOLINIT.F, never initialized, never used, never mentioned again
(Find only returns past usage that has since been commented out, as well as the single instance (definition) )

REAL         STUMPDIB, STUMPDOB: Declared in VOLINIT.F, never initialized, never used, never mentioned again
(Find only returns the single instance (definition) )

REAL         VOLIB, VOLOB: Declared in VOLINIT.F but not initialized prior to passing to RAILEVOL() where it is quickly assigned

REAL         DIB, DOB: Declared in VOLINIT.F but not initialized prior to being passed to CALCDIA2().  Will initialize each to 0.

REAL         FIAVOL Declared in VOLINIT.F.  Only instance of use has been commented out.  Can delete

REAL WF(3), BMS(8) Declared in VOLINIT.F.  Unused

INTEGER SPCD, FOREST Declared in VOLINIT.F.  Unused.

* BLMTAP.F: Removal and replacement of TAB characters

Comment out unused variable
   14 |       INTEGER    Profile,ILIMIT,ICOUNT,profileht
      |                                                1
Warning: Unused variable 'profileht' declared at (1) [-Wunused-variable]

C Temporary comment out of apparent unused variables, delete after test comfirms - 01/2023 DW
C      REAL         DBHIB

BLMVOL.F: Removal and replacement of TAB characters
blmvol.f:31:49:
Comment out:
   31 |       INTEGER PROFILE, bfpflg,cupflg,tlogs,ITAPER
      |                                                 1
Warning: Unused variable 'itaper' declared at (1) [-Wunused-variable]

blmvol.f:30:60:

   30 |       INTEGER EVOD,NUMSEG,OPT,TAPEQU,FCLASS,ERRFLAG,I,J,lcnt
      |                                                            1
Warning: Unused variable 'lcnt' declared at (1) [-Wunused-variable]

CalcDia.F: Removal and replacement of TAB characters

* Changed CHAR array length from 40 to 48 to address:
CRZBIOMASS.F:57:72:

   57 |             REF(6) = 'USE REGIONAL DEFAULT WEIGHT FACTOR (SECOND)'
      |                                                                        1
Warning: CHARACTER expression will be truncated in assignment (40/43) at (1) [-Wcharacter-truncation]
CRZBIOMASS.F:64:72:

   64 |              REF(6) = 'USE REGIONAL DEFAULT WEIGHT FACTOR (PRIM)'
      |                                                                        1
Warning: CHARACTER expression will be truncated in assignment (40/41) at (1) [-Wcharacter-truncation]
CRZBIOMASS.F:72:72:

   72 |             REF(5) = 'USE REGIONAL DEFAULT WEIGHT FACTOR (PRIM)'
      |                                                                        1
Warning: CHARACTER expression will be truncated in assignment (40/41) at (1) [-Wcharacter-truncation]
Files involved include:
CalcBiomass.F, subroutine getwtfactor_r
CRZBIOMASS.F, subroutine crzspdft, subroutine CRZBIOMASS
volibcs.f, subroutnine crzspdftcs
volumelibrary.f, subroutine BIOLIB, subroutine BIOLIB2

* Added initialization of drcq and drcp, which according to Chojnack, D. C. and Rogers, P. Converting Tree Diameter Measured at Root Collar
 to Diameter at Breast Height. WJAF 14(1), 1999, should be zero if not used
CRZBIOMASS.F:356:72:

  356 |      &   +0.7469*Pied-0.0399*drcp+1.2244*Quga-0.0689*drcq
      |                                                                        ^
Warning: 'drcq' may be used uninitialized [-Wmaybe-uninitialized]
CRZBIOMASS.F:335:35:

  335 |       REAL DRCOB, DBHOB, drcp, drcq
      |                                   ^
note: 'drcq' was declared here
CRZBIOMASS.F:356:72:

  356 |      &   +0.7469*Pied-0.0399*drcp+1.2244*Quga-0.0689*drcq
      |                                                                        ^
Warning: 'drcp' may be used uninitialized [-Wmaybe-uninitialized]
CRZBIOMASS.F:335:29:

  335 |       REAL DRCOB, DBHOB, drcp, drcq
      |                             ^
note: 'drcp' was declared here

dvest.f: Removed and replaced TAB characters
f_alaska: Removed and replaced TAB characters
f_ingy.f: Removed and replaced TAB characters
f_other.f: Removed and replaced TAB characters

Cast MLOGS to INT - INT(MLOGS)
fia_ak_vol.for:327:20:

  327 |         DO 10 I = 1,MLOGS
      |                    1
Warning: Deleted feature: End expression in DO loop at (1) must be integer

fia_ak_vol.f: Initialized variables

* Updated official SN/sitset.f
Updated merchantability specifications for National Forests in NC, per FSH 2409.18 Ch 50 Supplement R8_NC_2409.18-2022-1

* Update estab.f

Additional comments and debug statements were added for documentation purposes and to hopefully clarify some of the logic in this routine.

* Update estab.f

* Clean up of R5_EGN subroutine
Corrected other softwood FIA code in SO variant blkdat

* Initial event monitor expansion code to include
before and after stand height weighed by basal area.
STILL NEEDS TO BE VERIFIED AND TESTED

* Updated REV number for Q1 supplemental release

* Corrections to forest type algorithm when computing
other softwoods.  Change resultant from change of OS FIA code from 298 to 299.

Update to test/FVSie/DBReportTest_dump.txt.save
corrects issue with reporting ATCCF instead of BTCCF

* Corrections Included:
Corrected mapping issue for CR location 7104 to map to 203 (IFOR = 2) as misscoded I = 2)
Updated AK voleq for alder

* Updated to version and revision numbers for Q2

* clean up of X1 variable from fvsvol.f

* Added testing of the fvs[Get|Set]SpeciesAttrs code.

Fixed a bug in how stoppoint 7 works. Added more code to the test of the
APIviaR that would have shown the error had the test been added prior to
now.  Updated the 'save' files to account for these changes.

Added test for using fvsCutNow() option in rFVS and added code and
tests that trap using the thinprsc keyword in a way that causes a conflict
with the use of the rFVS fvsCutNow function.

* Initialization of variables in fmcfir.f
Label change for AK variant elevation reporting 10's feet to 100's feet

---------

Co-authored-by: Don Robinson <drobinson@essa.com>
Co-authored-by: Nicholas Crookston <ncrookston.fs@gmail.com>
Co-authored-by: LANCE R. DAVID <lance.david@usda.gov>
Co-authored-by: markcastle1415 <mark.castle@usda.gov>

---------

Co-authored-by: Don Robinson <drobinson@essa.com>
Co-authored-by: Nicholas Crookston <ncrookston.fs@gmail.com>
Co-authored-by: LANCE R. DAVID <lance.david@usda.gov>
Co-authored-by: markcastle1415 <mark.castle@usda.gov>